Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update Baidu.xml - #4584

Closed
ivysrono wants to merge 3 commits into
EFForg:masterfrom
ivysrono:patch-7
Closed

ivysrono wants to merge 3 commits into
EFForg:masterfrom
ivysrono:patch-7

Conversation

@ivysrono

@ivysrono ivysrono commented Apr 9, 2016

Copy link
Copy Markdown
Contributor

@mnordhoff

Copy link
Copy Markdown
Contributor

The XML syntax is off. You changed <!-- to < but didn't change --> to >. E.g.:

    <target host="pan.baidu.com" />

@ivysrono

ivysrono commented Apr 9, 2016

Copy link
Copy Markdown
Contributor Author

@mnordhoff Thanks.However,what is the error now?

@mnordhoff

Copy link
Copy Markdown
Contributor

There's a disabled ruleset called Baidu.com-problematic.xml that includes (only) the same two hosts you're adding to Baidu.xml. You should delete it.

@ivysrono

ivysrono commented Apr 9, 2016

Copy link
Copy Markdown
Contributor Author

@mnordhoff I have pull request to delete it yesterday. #4577

@mnordhoff

Copy link
Copy Markdown
Contributor

Oh. Then you've done everything right, but the tests don't know it because everything is in two separate pull requests. Your options are to wait until the other pull request is merged and trigger a retest; merge the branches together; or ignore the matter and cross your fingers.

@mnordhoff

Copy link
Copy Markdown
Contributor

For what it's worth, I tried it, and taking master 3b3df37 + merge #4577 45bb14c + merge #4584 9d7e9ab does pass Travis.

https://github.com/mnordhoff/https-everywhere/tree/Baidu-4577-4584
https://travis-ci.org/mnordhoff/https-everywhere/builds/121878198

So it ought to be safe to merge both pull requests as is, without further fiddling.

@J0WI J0WI closed this Apr 15, 2016
@J0WI J0WI reopened this Apr 15, 2016
@J0WI

J0WI commented Apr 15, 2016 •

Copy link
Copy Markdown
Contributor

There are some issues on open2 and yun (see Test log).
You may readd the problematic file for them.

@ivysrono

Copy link
Copy Markdown
Contributor Author

@J0WI Sorry,I do not know how to fix it.

@mnordhoff

mnordhoff commented Apr 17, 2016 •

Copy link
Copy Markdown
Contributor

@J0WI open2 and yun both work for me in-browser (Chrome), and with command line curl (using OpenSSL). This smells like a test suite problem.

https://www.ssllabs.com/ssltest/analyze.html?d=open2.baidu.com

open2's certificate chain is out of order, something that's a fail for pycurl but ignored by browsers.

(It also has a shockingly insecure TLS configuration, vulnerable to more than one MITM exploit, but browsers don't care about that.)

https://www.ssllabs.com/ssltest/analyze.html?d=yun.baidu.com

I can't figure what's wrong with this one... Edit: Some of its backends have an incomplete certificate chain. Okay, this one deserves to go on the problematic list.

@J0WI

J0WI commented Apr 26, 2016

Copy link
Copy Markdown
Contributor

See #2668 (comment) for the chain problem

@ivysrono ivysrono closed this May 11, 2016
@ivysrono

Copy link
Copy Markdown
Contributor Author

#4743

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants